Skip to content

CAT-945 - Update README.md LICENSE #1408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 20, 2023
Merged

CAT-945 - Update README.md LICENSE #1408

merged 2 commits into from
Nov 20, 2023

Conversation

Ramesh7
Copy link
Contributor

@Ramesh7 Ramesh7 commented Nov 15, 2023

Issue

  • The internal scanning tool requires to explicitly declare about dependent licenses for the given module.
  • CI is failing with docker provisioner due to filesystem mount issue.

Summary

Update README.md with declaring license details.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

README.md Outdated
@@ -577,6 +578,10 @@ As of Puppet Enterprise 3.7, the stdlib module is no longer included in PE. PE u

For an extensive list of supported operating systems, see [metadata.json](https://github.com/puppetlabs/puppetlabs-stdlib/blob/main/metadata.json)

## License

This codebase is licensed under the Apache2.0 licensing, however due to the nature of the codebase the open source dependencies may also use a combination of [AGPL](https://www.gnu.org/licenses/agpl-3.0.en.html), [GPL2.0](https://www.gnu.org/licenses/old-licenses/gpl-2.0.en.html) and [MIT](https://opensource.org/license/mit/) Licensing.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason you restrict it to AGPL, GPL2 and MIT?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the license list isn't complete, if you do a bundle install and then:

Gem.loaded_specs.each do |name, spec|
  puts "#{name}: #{spec.license}"
end

ansi: BSD-2-Clause
mutex_m: Ruby
pluginator: LGPL v3

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is to specifically meet some license scanning requirements in our internal tooling which wants us to make sure for those particular licenses we declare. Note we say may as were making a general statement across tools and modules

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @davidsandilands for putting background here and Thanks @bastelfreak for nice tip.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added missing one except Ruby one, not sure if we need to explicitly need to mention here, @davidsandilands please review and confirm the same. Thanks

rajat-puppet
rajat-puppet previously approved these changes Nov 20, 2023
@malikparvez malikparvez merged commit 1f66d39 into main Nov 20, 2023
@malikparvez malikparvez deleted the CAT-945-license-update branch November 20, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants